Build AcidInfo only for ORC-ACID tables #8259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Jun 11, 2021
Comment on lines
+718
to
+719
| AcidInfo.Builder acidInfoBuilder, | ||
| boolean isFullAcid) |
There was a problem hiding this comment.
should acidInfoBuilder be Optional?
| " 'line.delim'='\\n',\n" + | ||
| " 'serialization.format'=',')\n" + | ||
| " STORED AS INPUTFORMAT\n" + | ||
| " 'org.apache.hadoop.mapred.TextInputFormat'\n" + |
There was a problem hiding this comment.
We should cover Parquet as well.
Can there be some reuse between testReadInsertOnly? ideally they different in table file format definition?
| @@ -238,6 +238,63 @@ public void testReadInsertOnly(boolean isPartitioned, BucketingType bucketingTyp | |||
| } | |||
| } | |||
|
|
|||
| @Test(groups = HIVE_TRANSACTIONAL, dataProvider = "partitioningAndBucketingTypeDataProvider", timeOut = TEST_TIMEOUT) | |||
| @Flaky(issue = "https://github.com/trinodb/trino/issues/4927", match = "Hive table .* is corrupt. Found sub-directory in bucket directory for partition") | |||
| public void testReadNonOrcInsertOnly(boolean isPartitioned, BucketingType bucketingType) | |||
There was a problem hiding this comment.
bucketingType.getHiveClustering( seems to be missing, so bucketingType is effectively ignored.
| @@ -238,6 +238,63 @@ public void testReadInsertOnly(boolean isPartitioned, BucketingType bucketingTyp | |||
| } | |||
| } | |||
|
|
|||
| @Test(groups = HIVE_TRANSACTIONAL, dataProvider = "partitioningAndBucketingTypeDataProvider", timeOut = TEST_TIMEOUT) | |||
There was a problem hiding this comment.
Maybe we don't need all 4 combinations.
findepi
reviewed
Jun 11, 2021
| fileIterators.addLast(createInternalHiveSplitIterator(readPath, fs, splitFactory, splittable, acidInfoBuilder.build())); | ||
| Optional<AcidInfo> acidInfo = Optional.empty(); | ||
| if (isFullAcid) { | ||
| acidInfo = acidInfoBuilder.build(); |
There was a problem hiding this comment.
since the method is long anyway, let's use ?: for brevity and to have variables final.
|
Merged 79b34c5, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.