Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide STRING Parquet logical type annotation for char, varchar #9515

Merged
merged 1 commit into from Oct 8, 2021
Merged

Provide STRING Parquet logical type annotation for char, varchar #9515

merged 1 commit into from Oct 8, 2021

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 5, 2021

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2021
jirassimok
jirassimok approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@jirassimok jirassimok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jirassimok
Copy link
Member

jirassimok commented Oct 5, 2021 •
edited

It might be a good idea to do some style cleanup (static imports or line wrapping) in this file at some point to reduce all the long lines.

@findepi
Copy link
Member Author

findepi commented Oct 6, 2021 

tests               | 2021-10-06 00:37:12 INFO: FAILURE     /    io.trino.tests.product.hive.TestHiveCompression.testSnappyCompressedParquetTableCreatedInTrinoWithNativeWriter (Groups: hive_compression) took 1.9 seconds
tests               | 2021-10-06 00:37:12 SEVERE: Failure cause:
tests               | java.lang.AssertionError: 
tests               | Expecting code to raise a throwable.

it seems i accidentally fixed something for #6377
cc @joshthoward @anjalinorwood

@findepi findepi force-pushed the findepi/provide-string-parquet-logical-type-annotation-for-char-varchar-f8e201 branch 2 times, most recently from 3b5a318 to 6ce3fa3 Compare October 6, 2021 12:20
@findepi findepi force-pushed the findepi/provide-string-parquet-logical-type-annotation-for-char-varchar-f8e201 branch 2 times, most recently from 504ed95 to a94e8fd Compare October 6, 2021 20:52
@findepi findepi force-pushed the findepi/provide-string-parquet-logical-type-annotation-for-char-varchar-f8e201 branch from a94e8fd to af5f2ef Compare October 7, 2021 12:32
@findepi findepi merged commit a0347c6 into trinodb:master Oct 8, 2021
@github-actions github-actions bot added this to the 364 milestone Oct 8, 2021
@findepi findepi mentioned this pull request Oct 8, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint approved these changes

@losipiuk losipiuk losipiuk approved these changes

@jirassimok jirassimok jirassimok approved these changes

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

Assignees
No one assigned
Labels
cla-signed
Milestone
364
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@findepi @jirassimok @martint @losipiuk