Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change add PageTitle to query timeline #2511

Merged
merged 1 commit into from Jan 15, 2020
Merged

Change add PageTitle to query timeline #2511

merged 1 commit into from Jan 15, 2020

Conversation

dain
Copy link
Member

@dain dain commented Jan 15, 2020

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 15, 2020
@dain dain requested a review from raghavsethi January 15, 2020 00:58
raghavsethi
raghavsethi approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@raghavsethi raghavsethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raghavsethi
Copy link
Member

I would call this 'Add PageTitle to query timeline'

@dain dain merged commit 2afff46 into trinodb:master Jan 15, 2020
@dain dain deleted the timeline-page-title branch January 15, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavsethi raghavsethi raghavsethi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dain @raghavsethi