Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display schema in the presto-benchmark-driver result #5414

Merged
merged 1 commit into from Oct 27, 2020

Conversation

Lewuathe
Copy link
Member

@Lewuathe Lewuathe commented Oct 5, 2020

Since the presto-benchmark-driver does not show the schema name in the result, it's difficult to compare the performance between varied schemas when we specify multiple schemas in suites.json.

$ cat suites.json
{
  "mysuite": {
    "schema": [ "schema1", "schema2" ],
    "session": {
    },
    "query": []
  }
}

This PR modifies the driver to display the schema information too so that the comparison between multiple schemas can be easier.

Before

$ /path/to/presto-benchmark-driver/target/presto-benchmark-driver-342-SNAPSHOT-executable.jar --suite-config /path/to/suites.json --suite mysuite
suite	query	wallTimeP50	wallTimeMean	wallTimeStd	processCpuTimeP50	processCpuTimeMean	processCpuTimeStd	queryCpuTimeP50	queryCpuTimeMean	queryCpuTimeStd	status	error
mysuite	query1	10440	10397	115	63920	71353	16479	5664	5848	338	pass
mysuite	query1	12071	12037	96	13460	13436	535	1874	1876	9	pass
mysuite	query2	227170	236654	18988	600270	-201583	1401557	31388	29966	2930	pass
mysuite	query2	248531	201950	91342	122830	116373	33761	4788	5039	444	pass

After

$ /path/to/presto-benchmark-driver/target/presto-benchmark-driver-342-SNAPSHOT-executable.jar --suite-config /path/to/suites.json --suite mysuite
suite	schema	query	wallTimeP50	wallTimeMean	wallTimeStd	processCpuTimeP50	processCpuTimeMean	processCpuTimeStd	queryCpuTimeP50	queryCpuTimeMean	queryCpuTimeStd	status	error
mysuite	schema1	query1	10440	10397	115	63920	71353	16479	5664	5848	338	pass
mysuite	schema2	query1	12071	12037	96	13460	13436	535	1874	1876	9	pass
mysuite	schema1	query2	227170	236654	18988	600270	-201583	1401557	31388	29966	2930	pass
mysuite	schema2	query2	248531	201950	91342	122830	116373	33761	4788	5039	444	pass

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2020
@Lewuathe
Copy link
Member Author

It takes a while after it's approved. Is there anything I need to do on this?

@kokosing kokosing merged commit 379f245 into trinodb:master Oct 27, 2020
@kokosing
Copy link
Member

Merged, thanks!

@Lewuathe Lewuathe deleted the display-schema branch October 27, 2020 23:34
@Lewuathe
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants