Fix incorrect plan for implicit GROUP BY with HAVING #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
reviewed
May 9, 2019
presto-main/src/test/java/io/prestosql/sql/query/TestHaving.java
Outdated
Show resolved
Hide resolved
Per the SQL spec,
1) Let HC be the <having clause>. Let TE be the <table expression> that immediately
contains HC. If TE does not immediately contain a <group by clause>, then “GROUP BY ()”
is implicit.
dain
approved these changes
May 9, 2019
findepi
reviewed
May 10, 2019
| .assertQuery( | ||
| "SELECT 'x' FROM (VALUES 1, 1, 2) t(a) HAVING true", | ||
| "VALUES 'x'"); | ||
| } |
There was a problem hiding this comment.
This commit (intentionally) changes behavior. Previously:
presto> select a from (values 1,2,3) t(a) having a > 1;
a
---
2
3
now the query fails with
line 1:8: 'a' must be an aggregate expression or appear in GROUP BY clause
Would be good to have an explicit test for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the SQL spec,