Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquire password in cli when its stdout is a pipe #982

Merged
merged 1 commit into from Jun 18, 2019

Conversation

2 participants
@Praveen2112
Copy link
Member

commented Jun 13, 2019

Fixes #916

@electrum
Copy link
Member

left a comment

Few nits, otherwise looks good. Thanks for fixing this.

@Praveen2112 Praveen2112 force-pushed the Praveen2112:cli_password branch from 2198d9d to 92b479d Jun 18, 2019

@Praveen2112

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

@electrum Thanks for your insights. Have applied your comments.

@electrum electrum added this to the 316 milestone Jun 18, 2019

@electrum electrum merged commit 77ec764 into prestosql:master Jun 18, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
verification/cla-signed
Details

@electrum electrum referenced this pull request Jul 8, 2019

Closed

Release notes for 316 #1000

5 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.