Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n builds #271

Open
Rangi42 opened this issue Jul 12, 2020 · 7 comments
Open

i18n builds #271

Rangi42 opened this issue Jul 12, 2020 · 7 comments

Comments

@Rangi42
Copy link
Member

Rangi42 commented Jul 12, 2020

The French and German versions are already disassembled:

There were also Spanish, Italian, and Portuguese releases.

With a system like pokeruby has to keep different languages' data separate, so code files don't get cluttered with IF/ELSEs, these could all be in one repo.

See also: pret/pokecrystal#626 and https://github.com/mid-kid/pokecrystal/tree/splitting

@PikalaxALT
Copy link
Contributor

pokeruby doesn't have the best system for language separation. An ideal setup would specify sources to use for each locale. Simple setup:

ifeq ($(GAME_LANGUAGE),GERMAN)
LOC = de
else
LOC = en
endif

LOCALIZED_GFX := ...

$(LOCALIZED_GFX): %.2bpp: %.$(LOC).png

@Rangi42
Copy link
Member Author

Rangi42 commented Jul 12, 2020

Yeah, https://github.com/mid-kid/pokecrystal/tree/splitting has a workable system for that already with its version/ directory.

@mid-kid
Copy link
Member

mid-kid commented Jul 13, 2020

https://github.com/mid-kid/pokecrystal/tree/i18n/version might be a better example, lol.
The big drawback of the way this is written is that absolutely all of the graphics and object files are rebuilt for each version. This is fine in most rom hacking situations except when you want to make compare, which might take multiple minutes.
While I feel like the graphics situation can be improved, building only the necessary object files for each version is naught impossible without specifying them manually in a makefile.

@iimarckus
Copy link
Member

The French and German versions are already disassembled

@einstein95 also disassembled the Italian version; https://github.com/einstein95/pokered-it

“Petros” disassembled the Spanish version; the repository is no longer on GitHub but I mirrored it at https://git.poke.blue/pokered-es/

There were also Spanish, Italian, and Portuguese releases.

Are you sure there was a Portuguese release?

@rawr51919
Copy link
Contributor

rawr51919 commented Jun 22, 2022

There wasn't a Portuguese release, at least none that are on no-intro (checked with a quick search on their database)
There was, however, a Hong Kong/Chinese unofficial release from many, many pirate carts back in the day, yet because it's unofficial it doesn't make much sense for it to be added to i18n efforts

@einstein95
Copy link

@einstein95 also disassembled the Italian version; https://github.com/einstein95/pokered-it

I think that version I started but never finished

@rawr51919
Copy link
Contributor

rawr51919 commented Jun 28, 2022

fc17c5b904d551b1b908054ccd1c493f755f832a *pokered-es.gb
87d523fe1a0c548db7c5477b451ddec1eb083c06 *pokered-de.gb
47a7622fa30e6402a3891fe65b3a930bf9bd7aec *pokered-fr.gb
65b97cf8f2f1cff711a6d08c6c894c8ce65ce522 *pokered-it.gb
7715e7b133e8634df48918b9138374110212a108 *pokeblue-es.gb
20e72dc6f41493eee1fdd0cef54214e6c3389688 *pokeblue-de.gb
47faa910d0e073c600665bf9c83b6bd17babdf8a *pokeblue-fr.gb
f69ed1a1332f04c24c7db899a09019bb045fa8b3 *pokeblue-it.gb

The Japanese versions deserve their own project as they are different enough to warrant one:

0623ad12f48c259447980d68bd85ddbf8204b2cd *pokered-jp.gb
82c0eef40a5e2423699d9fd8ba15dfaa8b51d196 *pokegreen-jp.gb
ef74c79cded14204ac79e77f4964d9cb25003120 *pokered11-jp.gb
4b97cd44aa3f0dd290bfe7b3ac17b7bd8270897b *pokegreen11-jp,gb
0da501e3e5c51ab8fef55b092dcdd7e6b050e424 *pokeblue-jp.gb

The Chinese pirate versions, even though they aren't exactly official, may be deserving of their own project as well to see how the translators made sacrifices in the code to make those versions work:

66dc27a6998031e78042fcd24fcc053d78aabd2d *pokered-ch-pirate.gb
febdf81662e04443a307ff25892997c8ddd4e041 *pokeblue-ch-pirate.gb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants