Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing pictures results in Unsupported Color type? #18

Closed
Greatpriceman opened this issue Jun 28, 2016 · 4 comments
Closed

Editing pictures results in Unsupported Color type? #18

Greatpriceman opened this issue Jun 28, 2016 · 4 comments

Comments

@Greatpriceman
Copy link

Every time I edit a picture/sprite or resize it and then do the Make command, I get this:
"$ make
"graphics/title_screen/rubyversion.png" has an unsupported color type.
make: *** [graphics/title_screen/rubyversion.8bpp] Error 1"

Does anyone know why this is? and what fixes can be taken so that this error doesn't appear again?

@RevoSucks
Copy link
Collaborator

Use a proper image editing tool such as Graphics Gale. Color depth must be 4 or 8 in order to compress to the correct file.

@Greatpriceman
Copy link
Author

Greatpriceman commented Jun 28, 2016

I'll try that, now Do I edit the PNG files or the .bpp files?
it'll also show the error if the png has been edited, but not had the dimensions changed.
EDIT: ok, so I tried Graphics Gale, and it looks like when Edited in Microsoft Paint, the Edited files take on a 24Bpp instead of 8bpp color depth. Is there anyway for the code to downconvert the edited pngs to *bpp? (
being 1,2,4 or 8)

I guess I'll use Graphics Gale for the Time being, thanks for some of the help. :)

EDIT, New Problem: I've tried editing the Title Logo, and When I fill it all black, it messes up the title screen, and when I replace it with with a different piece of art, it breaks. it seems the only way to fix it is to leave the title logo and graphics as is. and Yes, I did try Graphics Gale for this.

@ghost
Copy link

ghost commented Jun 28, 2016

The problem is that the title screen logo is compressed so when you change it, the size changes. This causes subsequent data to have different addresses, which is a problem since the disassembly is not 100% done. You will need to find free space, put the new graphic there, and then repoint the logo for the time being, unfortunately.

@ghost
Copy link

ghost commented Sep 18, 2016

You should be able to modify compressed graphics without the game breaking now.

@ghost ghost closed this as completed Oct 30, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants