Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravitar checkbox should stay checked #1736

Closed
jidanni opened this issue Apr 6, 2024 · 3 comments
Closed

Gravitar checkbox should stay checked #1736

jidanni opened this issue Apr 6, 2024 · 3 comments
Labels
type: bug Needs fix

Comments

@jidanni
Copy link

jidanni commented Apr 6, 2024

Problem and impact

Editing our profile a second time shows the Gravitar button has oddly become unchecked.

Yes, there is a certain logic involved. But I would just keep it checked, once the user has checked it.

Screenshot 2024-04-06 13 09 30

That way each time he goes to Edit My Profile, he needn't think "huh, didn't I tell it to use my Gravitar?"

Yes even if lower down it says it is indeed using it.

@jidanni jidanni added the type: bug Needs fix label Apr 6, 2024
@rixx
Copy link
Member

rixx commented Apr 8, 2024

Keeping the checkbox checked would be somewhat misleading, as it would imply that any update on the Gravatar side would get synced to pretalx. That is not the case – due to privacy concerns, we retrieve the image from Gravatar once, and then serve it ourselves. Checking the box again will start the sync again.

I can see a case for an interface that isn't a checkbox next to the "Retrieve profile picture", and instead something like a button, and I'd merge a PR making this change, but other than that, I'd consider this out of scope for now.

@rixx rixx closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@jidanni
Copy link
Author

jidanni commented Apr 9, 2024

Holy smokes. I thought the whole point of gravitar is no matter what you changed all the other sites following it would change with it.

We'll you got to add an explanation there that it's only synced once!

Otherwise everybody will think it's just like the all the other sites that use gravitar, they just stay in sync.

I don't even know if this is consistent with gravitar's terms of use!

@rixx
Copy link
Member

rixx commented Apr 9, 2024

I don't see how this would violate the TOS of Automattic, who (as far as I can tell) do not have separate TOS for Gravatar. If, however, you can point out where pretalx violates the TOS of Gravatar/Automattic, I'd of course stop doing so immediately and disable our Gravatar integration! As that's a topic of legal bearing, please contact info at pretalx.com for further discussion.

@pretalx pretalx locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Needs fix
Projects
None yet
Development

No branches or pull requests

2 participants