Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email of the speakers in the API #493

Closed
Rafiot opened this issue Sep 6, 2018 · 6 comments
Closed

Email of the speakers in the API #493

Rafiot opened this issue Sep 6, 2018 · 6 comments

Comments

@Rafiot
Copy link
Contributor

@Rafiot Rafiot commented Sep 6, 2018

Problem you are facing

I want to send unique registrations tokens to each speaker individually

Possible Solution

  1. Use the web interface to mail each speaker one after the other, copy/paste the template, change the token (time consuming)
  2. Get the name and the email address from pretalx with the API, generate & send all the emails at once (faster, but the emails aren't exported in the API)
@rixx
Copy link
Member

@rixx rixx commented Sep 6, 2018

Right, we need to take care that emails are only exposed to organisers. Other than that, I see no issue with this.

@derchrisuk
Copy link

@derchrisuk derchrisuk commented Oct 18, 2018

I implemented this for another project

derchrisuk@d3e2099

I guess if you only want the email in the results, then the changes in src/pretalx/api/serializers/speaker.py should be enough

@rixx
Copy link
Member

@rixx rixx commented Oct 18, 2018

Well, the changes you made expose the speaker emails publicly, as far as I can tell – that's not a good idea at all, since the speakers haven't agreed to a public display of their email address.

@derchrisuk
Copy link

@derchrisuk derchrisuk commented Oct 18, 2018

They should not, as the change is done in the SpeakerOrgaSerializer, which should only be accessible by Orga members

@rixx
Copy link
Member

@rixx rixx commented Oct 18, 2018

Right, then the only thing it's missing is a Pull-Request with documentation and tests.

@derchrisuk
Copy link

@derchrisuk derchrisuk commented Oct 18, 2018

If I find the time I will have a look at it.
Would need to look into tests though, never written one before.

@rixx rixx closed this in 16625bd Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.