/pretalx

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of reviews returns 404 if it is my own talk #529

Closed
Nakaner opened this Issue Nov 10, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@Nakaner @rixx
@Nakaner

Nakaner commented Nov 10, 2018

Expected Behavior

either a proper error message like "You are not allowed to see the reviews of your own talk." or just show them

Current Behavior

status cod 404

Steps to Reproduce

  1. Be the admin of an event
  2. Submit a talk (in this case it was the first submission to the event at all)
  3. Many other submissions by other speakers happen (I don't know if that is relevant at all)
  4. Reviewers submit a few reviews to some talks
  5. I want to see the reviews of my talk (I don't know if anyone has sent a review for that talk at all) and call /orga/event/fossgis2019/submissions/ID/reviews

Your Environment

pretalx.com, FOSSGIS 2019
@rixx

This comment has been minimized.

Sign in to view
Member

rixx commented Nov 10, 2018

It's intentional that speakers cannot see the reviews of their own talk. I agree that a better error message than a 404 would be appropriate, though.

@rixx rixx added size:small stage:up for grabs issue:ux labels Nov 10, 2018

@rixx rixx closed this in 00927bf Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment