Thought: vscode solidity integration

[juanfranblanco]

Hi,

Happy new year. You have done an amazing job with the plugin to prettier, have you thought about having it fully integrated with the vscode solidity extension?

[fvictorio]

Hi @juanfranblanco and thanks!

What do you mean by having it fully integrated? There are some instructions in the readme on how to use it with VS (added in #200 for reference), but I'm not sure if that's what you're talking about.

[juanfranblanco]

Oh I mean, in the same way that the linters are included as part of the extension, to include prettier + the solidity plugin in the same way, so users can just press Ctrl + K and format the document instantly. Users this way just need to provide their preferences.

Edit: BTW I can do this myself, just validating your thoughts as I don't want to add more tasks to you.

[fvictorio]

I think it's a great idea, just keep in mind that this project is still in an alpha stage. And if you need something done on our side, just comment it in this issue. (I don't want to speak for @mattiaerre and @Janther, but I guess they are probably OK with this too).

Please let us know after is done so we can update the readme with the proper instructions.

[mattiaerre]

of course @fvictorio and thanks @juanfranblanco we are more than happy to accept PRs we love OSS 😊

[juanfranblanco]

@mattiaerre @Janther @fvictorio I have added it now the plugin and prettier as the formatter for the vscode solidity extension https://github.com/juanfranblanco/vscode-solidity/blob/master/README.md#formatting-using-prettier-and-the-prettier-solidity-plugin and obviously all the credit to you https://github.com/juanfranblanco/vscode-solidity/blob/master/README.md#credits.

Let's see how it goes for now I have included the functionality to only format per document using the context menu or Shift+Alt+F

[mattiaerre]

this is awesome, thanks so much @juanfranblanco we really appreciate that 🙏 how does it work for you? does it seem good enough? can I ask you to add to the credits also the link to this repo so that other people are aware of it and they can start collaborating? thanks again

[juanfranblanco]

It is working very well, (lets wait to see what users think about it) and sure ill add more links :)

[Janther]

@juanfranblanco You might want to support .prettierignore.
at the moment the plugin is formatting our tests 🤣 which kinda beats the purpose of having them.

[juanfranblanco]

@Janther just seen this!! sure ill added it.

[juanfranblanco]

@Janther done, have a look

[mattiaerre]

I think we can close this issue right @juanfranblanco ?

[juanfranblanco]

@mattiaerre sure! Ill update the plugin in each release :)