Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parseInterpolationExpression, deprecate parseInterpolation #241

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Jan 19, 2023

I found there is another parseInterpolationExpression method, so we don't need wrap input with {{}}.

@fisker fisker changed the title feat: add parseInterpolationExpression feat: add parseInterpolationExpression, deprecate parseInterpolation Jan 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4dffea2) compared to base (96d2da7).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4dffea2 differs from pull request most recent head ab91e41. Consider uploading reports for the commit ab91e41 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          302       299    -3     
  Branches        80        80           
=========================================
- Hits           302       299    -3     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fisker fisker marked this pull request as ready for review January 19, 2023 04:24
@fisker fisker requested a review from thorn0 January 19, 2023 04:29
@fisker fisker merged commit 817b64a into prettier:main Jan 30, 2023
@fisker fisker deleted the parseInterpolationExpression branch January 30, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants