Build failing at plugin:vue/no-layout-rules #70
Comments
|
cc @michalsnik |
|
I tried to reproduce this. .eslintrc: {
"extends": [
"plugin:vue/recommended",
"prettier/vue"
]
}package.json test.vue: If I comment out And with Are you using ESLint via some other tool? Maybe the error only happens when not using the |
|
.eslintrc package.json Install https://github.com/chrisvfritz/vue-enterprise-boilerplate and build. |
|
Thanks! Can you make a smaller example?
|
|
After 7 minutes it finally finished. I ran |
|
I had this same issue. I downgraded to 4.0.0 and everything worked fine. But 4.0.1 fails to lint. {
"devDependencies": {
"@babel/core": "^7.2.2",
"@vue/cli-plugin-babel": "^3.3.0",
"@vue/cli-plugin-eslint": "^3.3.0",
"@vue/cli-plugin-unit-jest": "^3.3.0",
"@vue/cli-service": "^3.3.0",
"@vue/eslint-config-prettier": "^4.0.1",
"@vue/test-utils": "^1.0.0-beta.28",
"babel-core": "^7.0.0-bridge.0",
"babel-jest": "^23.6.0",
"decamelize": "^2.0.0",
"lint-staged": "^8.1.0",
"node-sass": "^4.11.0",
"sass-loader": "^7.0.1",
"style-resources-loader": "^1.2.1",
"vue-cli-plugin-i18n": "^0.5.1",
"vue-cli-plugin-style-resources-loader": "^0.1.3",
"vue-template-compiler": "^2.5.21"
}
}The exception: |
|
4.0.0 and 4.0.1 of what package? |
Sorry! I meant that I had to downgrade "@vue/eslint-config-prettier" which fails to lint on 4.0.1, but works fine on 4.0.0 |
|
Both 4.0.0 and 4.0.1 of @vue/eslint-config-prettier depend on eslint-config-prettier@^3.3.0, so 4.0.1 should be as working/broken as 4.0.0. It depends on which eslint-config-prettier version is in your package-lock.json/yarn.lock. |
|
@frozofreak I just realized that chrisvfritz/vue-enterprise-boilerplate contains eslint-config-prettier@3.3.0 in its yarn.lock, while the it’s 3.4.0 that introduced the problem you have: Could you (or @ryuuji3) please make a minimal example repo where we can debug? I don’t use Vue myself, so I don’t feel like spending so much time on it right now. |
|
update |
|
Thanks, @liaoyinglong. I now realize that 3.4.0 should have been released as 4.0.0 as this seems to be a breaking change :( |
|
I get the same error, and did: yarn why eslint-plugin-vue
yarn why v1.13.0
[1/4] Why do we have the module "eslint-plugin-vue"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "eslint-plugin-vue@4.7.1"
info Reasons this module exists
- "@vue#cli-plugin-eslint" depends on it
- Hoisted from "@vue#cli-plugin-eslint#eslint-plugin-vue"
Done in 1.53s.Which leads to the question: Might it be correct to have eslint-plugin-vue referenced in peerDependencies and not only in devDependencies? |
Yes, that would emit a warning if the wrong version of eslint-plugin-vue is installed. But unfortunately there are a lot of users of this package who don't use vue and they would get annoying warnings. |
|
I think I'll have to revert #69 and publish a new version. |
|
@lydell Would it be possible to somehow make it conditional? Like often used in vue-cli: |
|
@ldrick I don't think so, but I'm open for suggestions! |
|
Maybe we should revert that PR anyway, because sometimes there are layout rules that don't conflict with Prettier but rather complement it. |
|
I’ve published 3.5.0 that reverts back to how 3.3.0 worked. Update all the things in your repos and things should work again! |
While trying to compile my project, I get the following error
Module build failed (from ./node_modules/eslint-loader/index.js):
Error: Failed to load config "plugin:vue/no-layout-rules" to extend from.
Referenced from Referenced from: /node_modules/eslint-config-prettier/vue.js
project build from few days back works fine. Its the latest build which is failing. Any suggestions
The text was updated successfully, but these errors were encountered: