Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With eslint fix mode, and using eslint-config-prettier, I still get lint errors every time. #45

Closed
trusktr opened this issue Aug 22, 2017 · 4 comments

Comments

@trusktr
Copy link

trusktr commented Aug 22, 2017

I was hoping that running fix mode of eslint would cause the prettier plugin to fix stuff, and there would be no more prettier-related lint errors, but that isn't the case. Maybe eslint-config-prettier needs an update?

Here's a branch (in the wrong repo) that you can reproduce from: https://github.com/trusktr/gulp-eslint/tree/issue-204

Just clone that repo and checkout that issue-204 branch, npm i, then run ./node_modules/.bin/gulp lint a few times, and each time the output will continue to show prettier-related errors.

I thought there would be no prettier errors at least the second round if it fixed everything the first round.

@not-an-aardvark
Copy link
Member

Is this the same issue as eslint/eslint#9142?

@trusktr
Copy link
Author

trusktr commented Aug 23, 2017

Yep, it is. I wasn't sure where to post.

@trusktr
Copy link
Author

trusktr commented Aug 23, 2017

Not a prettier issue though.

@trusktr trusktr closed this as completed Aug 23, 2017
@trusktr
Copy link
Author

trusktr commented Aug 24, 2017

It turns out it is eslint's fault: eslint/eslint#9142 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants