Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: appveyor #695

Merged
merged 2 commits into from Oct 3, 2018
Merged

ci: appveyor #695

merged 2 commits into from Oct 3, 2018

Conversation

alexander-akait
Copy link
Member

/cc @vjeux looks we don't have permissions to add project https://ci.appveyor.com/project/prettier/plugin-php

@alexander-akait
Copy link
Member Author

Looks we have bug with pragma on windows 😕

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

Do you know what kind of permission it requires, you are admin on the project:

image

When I click on that link I see

image

but I don't have an appveyor account

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

I was able to create https://ci.appveyor.com/project/vjeux/plugin-php still trying to get it under prettier account...

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

@evilebottnawi I added you as admin of the prettier org itself. Please let me know if you can make it work. I don't understand how to do it from their UI :x

@alexander-akait
Copy link
Member Author

@vjeux still not enough rights/permissions 😞 For other projects i have "+ New project" in the top left side. You can change account in upper top left side - just click on account/organization name. Maybe need add me here https://ci.appveyor.com/account/prettier/team

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

What's your appveyor email?

@alexander-akait
Copy link
Member Author

@vjeux Usually this is used to avoid addition and removal (after setup hook appveyor should add permissions to all administrators of repo) https://ci.appveyor.com/account/prettier/github-teams

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

Can you try again now?

@alexander-akait
Copy link
Member Author

@vjeux no, looks you add me access to you account, not prettier org

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

Grrrrr!! Sorry let me try again in 10min when I’m at my desk :(

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

When I go to the prettier url, unfortunately it assumes that it's for vjeux... I don't know how to change it to use prettier.

image

@alexander-akait
Copy link
Member Author

@vjeux very strange, maybe we should ask someone for help

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

On a positive note, it seems to be working: https://ci.appveyor.com/project/vjeux/plugin-php/build/1.0.1

@alexander-akait
Copy link
Member Author

@vjeux maybe need remove repo from personal account and readd to org?

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

Let me delete it and then you can try to add it to the org. You are admin of the prettier org on github so you should be able to do it.

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

Done

@alexander-akait
Copy link
Member Author

alexander-akait commented Oct 1, 2018

@vjeux Can't add 😞 What the hell with appveyor 😕

@alexander-akait
Copy link
Member Author

@vjeux Can you have access to https://ci.appveyor.com/account/prettier/team? Maybe you can add me as Administrator (sheo13666q@gmail.com) and i try to find how it should be setup

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

You are already an admin when I look at this page...

image

@alexander-akait
Copy link
Member Author

alexander-akait commented Oct 1, 2018

@vjeux you should switch account to prettier, you screenshot show what you add me as Administrator for you account (vjeux), not prettier. Just click on account name on navbar and switch to prettier (near with logo)

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

I can't do that...

image

@alexander-akait
Copy link
Member Author

@vjeux it seems that someone else has rights, who set up appveyor for prettier? Maybe he/she/it forgot setup github org hook for access

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2018

I have no idea who that would be...

@alexander-akait
Copy link
Member Author

@alexander-akait
Copy link
Member Author

Awesome, windows tests passed

@alexander-akait alexander-akait merged commit 4348691 into master Oct 3, 2018
@alexander-akait alexander-akait deleted the ci-appveyor branch October 3, 2018 12:11
@azz
Copy link
Member

azz commented Oct 7, 2018

I remember this being a headache when setting up for prettier/prettier. I think it was @duailibe or @ikatyang who got the account moved from my personal?

@ikatyang
Copy link
Member

ikatyang commented Oct 7, 2018

It's me. (I forgot to mention here that the discussion has been moved to prettier/prettier#5181.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants