Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Faulty Insert ; error since v2.4.0 #428

Closed
lehni opened this issue Jan 22, 2023 · 1 comment · Fixed by #429
Closed

Bug: Faulty Insert ; error since v2.4.0 #428

lehni opened this issue Jan 22, 2023 · 1 comment · Fixed by #429
Assignees
Labels
type: bug Functionality that does not work as intended/expected

Comments

@lehni
Copy link
Collaborator

lehni commented Jan 22, 2023

Info

Tool Version
Plugin v2.4.0
Prettier v2.8.3
Framework vue
Node v18.12.0
OS mac

Prettier config

{
  "printWidth": 80,
  "semi": false,
  "singleQuote": true,
  "quoteProps": "consistent",
  "arrowParens": "avoid",
  "trailingComma": "none",
  "pugFramework": "vue",
  "pugSingleQuote": false,
  "pugAttributeSeparator": "none",
  "pugCommentPreserveSpaces": "trim-all",
  "pugWrapAttributesThreshold": 1,
  "pugWrapAttributesPattern": "^(@|v-)"
}

Input

<template lang="pug">
some-component(
  v-if="item"
  @input="(...args) => onInput(item, ...args)"
)
</template>

Output or Error

3:10  error  Insert `;`  prettier/prettier

Expected Output

<template lang="pug">
some-component(
  v-if="item"
  @input="(...args) => onInput(item, ...args)"
)
</template>

Additional Context

This used to work in 2.3.0. I suspect #426 is the culprit

@lehni lehni changed the title Bug: Faulty "Insert ;" error since v2.4.0 Bug: Faulty ``Insert ;```` error since v2.4.0 Jan 22, 2023
@lehni lehni changed the title Bug: Faulty ``Insert ;```` error since v2.4.0 Bug: Faulty Insert \;\`` error since v2.4.0 Jan 22, 2023
@lehni lehni changed the title Bug: Faulty Insert \;\`` error since v2.4.0 Bug: Faulty Insert ; error since v2.4.0 Jan 22, 2023
@Shinigami92 Shinigami92 added the type: bug Functionality that does not work as intended/expected label Jan 22, 2023
@Shinigami92 Shinigami92 self-assigned this Jan 22, 2023
@lehni
Copy link
Collaborator Author

lehni commented Jan 26, 2023

Thank you @Shinigami92 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants