Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts for updating the version #39

Open
lipis opened this issue Oct 16, 2019 · 5 comments
Open

Add scripts for updating the version #39

lipis opened this issue Oct 16, 2019 · 5 comments
Labels
internal This change is not user facing release This is related to releasing the Chrome extension

Comments

@lipis
Copy link
Member

lipis commented Oct 16, 2019

It should

  • update the version (patch, minor, major) in package.json and manifest.json
  • commit the changes
  • create a new tag with that version
  • push the changes to GitHub
@kaicataldo kaicataldo added internal This change is not user facing release This is related to releasing the Chrome extension labels Oct 16, 2019
@nickmccurdy
Copy link
Member

nickmccurdy commented Oct 16, 2019

The first three are built into yarn version. Then you just need to push with your preferred git client.

@lipis
Copy link
Member Author

lipis commented Oct 17, 2019

but not the manifest.json.. We need have scripts like:

yarn release:patch
yarn release:minor
yarn release:major

@nickmccurdy
Copy link
Member

Ah I misunderstood, good point. I wonder if we can hook onto these scripts like with postinstall. Also Mozilla's web-ext tool may help automate this, otherwise it's not too difficult to edit a JSON file with Node scripts.

@lipis
Copy link
Member Author

lipis commented Oct 17, 2019

Nothing fancy.. my idea was to have node scripts anyway.

@felixmosh
Copy link

This is how I’m syncing package.json version with manifest, https://github.com/felixmosh/10bis-chrome-extension/blob/master/webpack.config.js#L109 maybe can be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal This change is not user facing release This is related to releasing the Chrome extension
Projects
None yet
Development

No branches or pull requests

4 participants