eslintignore

[calebeby]

Hi,

It would be awesome if prettier-eslint would support ignoring files in the eslintIgnore field in the package.json

Here's the relevant docs: https://eslint.org/docs/user-guide/configuring#using-eslintignore-in-packagejson

[kentcdodds]

Thanks for the idea! Sounds like that'd be useful! Feel free to make a pull request 😀

[calebeby]

I figured you'd ask 😄
I looked at the code a bit, can you point me to which function I should add the logic to?

[kentcdodds]

Relevant code here:

prettier-eslint-cli/src/format-files.js

Lines 251 to 264 in 0d101e4

	function isFilePathMatchedByEslintignore(filePath) {
	const eslintignorePath = getNearestEslintignorePath(filePath)
	if (!eslintignorePath) {
	return false
	}
	const eslintignoreDir = path.parse(eslintignorePath).dir
	const filePathRelativeToEslintignoreDir = path.relative(
	eslintignoreDir,
	filePath,
	)
	const isIgnored = getIsIgnoredMemoized(eslintignorePath)
	return isIgnored(filePathRelativeToEslintignoreDir)
	}

Similar tests are here:

prettier-eslint-cli/src/format-files.test.js

Lines 192 to 235 in 0d101e4

	test('wont modify a file if it is eslint ignored', async () => {
	await formatFiles({_: ['src/**/ignored*.js'], write: true})
	expect(fsMock.readFile).toHaveBeenCalledTimes(1)
	expect(fsMock.writeFile).toHaveBeenCalledTimes(1)
	expect(fsMock.readFile).toHaveBeenCalledWith(
	expect.stringMatching(/applied/),
	'utf8',
	expect.any(Function),
	)
	expect(fsMock.writeFile).toHaveBeenCalledWith(
	expect.stringMatching(/applied/),
	expect.stringMatching(/MOCK_OUTPUT.*?applied/),
	expect.any(Function),
	)
	const ignoredOutput = expect.stringMatching(/success.*1.*file/)
	expect(console.error).toHaveBeenCalledWith(ignoredOutput)
	})
	test('will modify a file if it is eslint ignored with noIgnore', async () => {
	await formatFiles({
	_: ['src/**/ignored*.js'],
	write: true,
	eslintIgnore: false,
	})
	expect(fsMock.readFile).toHaveBeenCalledTimes(4)
	expect(fsMock.writeFile).toHaveBeenCalledTimes(4)
	const ignoredOutput = expect.stringMatching(/success.*4.*files/)
	expect(console.error).toHaveBeenCalledWith(ignoredOutput)
	})
	test('will not blow up if an .eslintignore cannot be found', async () => {
	const originalSync = findUpMock.sync
	findUpMock.sync = () => null
	try {
	await formatFiles({
	_: ['src/**/no-eslint-ignore/*.js'],
	write: true,
	})
	} catch (error) {
	throw error
	} finally {
	findUpMock.sync = originalSync
	}
	})

Good luck! And thanks :)

[calebeby]

I realized you were right about not needing this project, so I'm not going to create a PR for this. Feel free to close this if you want, or just let it open.

[github-actions]

Stale issue