Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the equivalent of prettier -l option #38

Closed
kennydee opened this issue Mar 9, 2017 · 3 comments
Closed

Have the equivalent of prettier -l option #38

kennydee opened this issue Mar 9, 2017 · 3 comments

Comments

@kennydee
Copy link

kennydee commented Mar 9, 2017

Hi,
First, thanks for your work, this is very usefull !

Is there anyway to have a -l option equivalent to the one from prettier to know what are the file that are not prettier-eslint yet ?

See the PR from the prettier repos adding this option : prettier/prettier#854

It could be usefull to be able to launch prettier-eslint -l "src/**/*.js to check on CI if all the files have passed the prettier-eslint script.

P.S: we can't use the -l from prettier here because it doesn't rely on Eslint config.

Thanks

Kenny

@kentcdodds
Copy link
Member

Sure, I'd be fine to accept a PR that does this. We can't use -l though because that's an alias to --log-level so we'd need to come up with something else. Feel free to makeapullrequest.com :)

@kennydee
Copy link
Author

Ok will see :)

For now, i have found a workaround to achieve the same goals :
I've added eslint-plugin-prettier to my project, so lint (and CI) will failed if files are not prettier formated.

Will see if this is enough, or if a check option for prettier-eslint is always needed.

Thanks for your feedback.
Feel free to close if you think so.

@kentcdodds
Copy link
Member

I'll go ahead and close, but anyone can feel free to bring this up again. I'd be happy to accept a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants