prettier-eslint-cli does not throw eslint's errors

[arfa]

• prettier-eslint-cli version: 4.1.1
• prettier-eslint version: 6.4.2
• prettier version: 1.5.2
• eslint version: 3.19.0

.eslintrc:

{
  "env": {
    "browser": true,
    "es6": true
  },
  "parser": "babel-eslint",
  "parserOptions": {
    "ecmaFeatures": {
      "jsx": true
    }
  },
  "extends": "defaults",
  "plugins": [
    "react"
  ],
  "rules": {
    "no-console": 2,
    "no-const-assign": 2,
    "no-unused-vars": 2,
    "prefer-const": 2,
    "semi": 2,
    "comma-dangle": 0,
    "react/jsx-uses-react": 2,
    "react/jsx-uses-vars": 2
  }
}

Problem description:

I have "no-console": 2 in my .eslintrc file.
I put a console.log in my code so when I run the command eslint it throws an error.

However when I run prettier-eslint it doesn't show this error (I have tried all the --log-level possible values).

If I am not missing something, it is supposed to show the error as it is mentioned in prettier-eslint

prettier-eslint will propagate errors when either prettier or eslint fails for one reason or another. In addition to propagating the errors, it will also log a specific message indicating what it was doing at the time of the failure.

[kentcdodds]

Hi @arfa, 👋

That phrase in the docs is referring to errors thrown (like when parsing), not errors in the rules. prettier-eslint is focused only on formatting things that can be formatted, not about reporting rule violations. It is intended to be used completely separately from eslint (you should have both).

So you use prettier-eslint to autoformat your code, and eslint to find issues which cannot be autofixed.

I hope that helps.

[arfa]

Hi @kentcdodds

Thanks you for your response. it is clear now 👍

Maybe you should specify that in the docs.
I think it is important to know that we should have both.

[kentcdodds]

Agreed. Would you like to makeapullrequest.com? 😄

[arfa]

I will do it 😄

It will be a PR on prettier-eslint

[humanchimp]

Our tree is large and it would be nice to only have to run one tool to format the files when nothing else is wrong, but that would throw when other eslint rules are violated so we don't need to run the expensive operation against the entire tree twice. I can understand that it's not the default behavior, but it seems reasonable to allow that as a configuration.