feat: ✨ Add TypeScript definitions #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemh
approved these changes
May 7, 2022
|
Shall we? I'm hella down for that but it's gonna take time |
|
That's what I was trying to get across in DefinitelyTyped/DefinitelyTyped#54526 No need to do type declarations if we just go to TypeScript. As an aside, it appears as though this has caused CI to fail 👀 |
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 99.65% 99.66% +0.01%
==========================================
Files 2 2
Lines 287 298 +11
Branches 78 88 +10
==========================================
+ Hits 286 297 +11
Misses 1 1
Continue to review full report at Codecov.
|
kylemh
approved these changes
May 14, 2022
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved here from DefinitelyTyped/DefinitelyTyped#54526 - see context in #575.
@kylemh