Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add __babel-estree parser #10406

Closed
fisker opened this issue Feb 25, 2021 · 0 comments · Fixed by #10910
Closed

Proposal: Add __babel-estree parser #10406

fisker opened this issue Feb 25, 2021 · 0 comments · Fixed by #10910
Assignees
@fisker
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:enhancement A potential new feature to be added, or an improvement to how we print something

Comments

@fisker
Copy link
Sponsor Member

fisker commented Feb 25, 2021 •
edited

The @babel/eslint-parser generate a different shape of AST.

I propose add this private parser to valid that we can also print this AST, so maybe we can really skip parsing in eslint-plugin-pretter someday.

I think this won't be hard, we only need enable estree plugin.

WDYT?
@fisker fisker added type:enhancement A potential new feature to be added, or an improvement to how we print something status:needs discussion Issues needing discussion and a decision to be made before action can be taken labels Feb 25, 2021
@fisker fisker mentioned this issue Mar 4, 2021
Merged
4 tasks
@fisker fisker self-assigned this Mar 5, 2021
@fisker fisker removed the status:needs discussion Issues needing discussion and a decision to be made before action can be taken label Mar 5, 2021
@fisker fisker mentioned this issue May 18, 2021
Merged
4 tasks
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fisker fisker

Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:enhancement A potential new feature to be added, or an improvement to how we print something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add __babel_estree parser fisker/prettier
1 participant
@fisker