Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Husky v5 is not MIT #10461

Closed
hg-pyun opened this issue Mar 4, 2021 · 2 comments
Closed

Husky v5 is not MIT #10461

hg-pyun opened this issue Mar 4, 2021 · 2 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. scope:external This is not an issue with Prettier, it’s an issue with external software, like an editor integration type:docs Issues about adding or improving documentation

Comments

@hg-pyun
Copy link

hg-pyun commented Mar 4, 2021 •
edited

Hello. Starting with husky v5 version, they use an early access license, not an MIT license. Therefore, it is not commercially available, but caution is needed when using the Pretier Pre-Commit Hook. Wouldn't it be better to add a reminder on the https://prettier.io/docs/en/precommit.html page?

Reference

https://dev.to/typicode/what-s-new-in-husky-5-32g5
@thorn0 thorn0 added scope:external This is not an issue with Prettier, it’s an issue with external software, like an editor integration type:docs Issues about adding or improving documentation labels Mar 4, 2021
@thorn0
Copy link
Member

thorn0 commented Mar 4, 2021

npx mrm lint-staged, the command recommended in Prettier's docs, installs Husky 4.x. See sapegin/mrm#146

@thorn0 thorn0 closed this as completed Mar 4, 2021
@hg-pyun
Copy link
Author

hg-pyun commented Mar 4, 2021

@thorn0 Got it. Good.

@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jun 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. scope:external This is not an issue with Prettier, it’s an issue with external software, like an editor integration type:docs Issues about adding or improving documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thorn0 @hg-pyun