Remove AstPath(aka FastPath)

[fisker]

It's hard to access ancestors, why can't we use .parent like ESLint do?

And it's a state machine, remove it so maybe we can print node in parallel, by worker?

[sosukesuzuki]

pros and cons I think other than what fisker gives:

Pros

• Easy to understand to usage of AST especially for first-time contributors.

Cons

• It's a refactoring with a lot of changes. So it may not be cost effective.
• Flexible operations may be lost? (e.g. path.match)

[fisker]

Flexible operations may be lost? (e.g. path.match)

I think similar function for node not hard to implement.

[fisker]

The FastPath history benjamn/recast#139

[siefkenj]

As a plugin author, I find AstPath an endless source of frustration. I often want to reparse or modify the AST on-the-fly to add metadata/etc during printing. I haven't found an easy way to do that because AstPath is locked to the initial AST. At a minimum, it should be exported so plugins can create new AstPath objects...

[fisker]

it should be exported so plugins can create new AstPath objects

const AstPath = path.constructor

Not recommanded, but possible :)

[thorn0]

It's hard to access ancestors

Seriously?

why can't we use .parent like ESLint do?

Use it where it's available. Nothing stops you.

remove it so maybe we can print node in parallel, by worker

Clone it if needed. Essentially it's just an array. It doesn't have to be a singleton. print doesn't have to be bound to it.