Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailingComma option is not applied after spread in object #1079

Closed
jonathanglasmeyer opened this issue Mar 23, 2017 · 5 comments
Closed

trailingComma option is not applied after spread in object #1079

jonathanglasmeyer opened this issue Mar 23, 2017 · 5 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@danharper
Copy link
Contributor

A trailing comma isn't allowed after the rest operator.

The rationale for this is that the use case for trailing comma is that you can add something at the end without affecting the line above. E.g. for version control software. However, that is never the case here.
babel/babylon#149 (comment)

(It's currently parsed by Babel v6, but only for back-compat reasons. Babel v7 will be spec compliant and disallow it)

@jonathanglasmeyer
Copy link
Author

Nice, thanks for the info!

@vjeux
Copy link
Contributor

vjeux commented Aug 21, 2017

@thgreasi can you open an issue on tslint so that they can fix it?

@thgreasi
Copy link

Opened palantir/tslint#3147 for this.

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

4 participants