Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary this is added to shorthand properties in Angular templates #12138

Closed
th0r opened this issue Jan 24, 2022 · 2 comments · Fixed by #12993
Closed

Unnecessary this is added to shorthand properties in Angular templates #12138

th0r opened this issue Jan 24, 2022 · 2 comments · Fixed by #12993
Labels
area:multiparser Issues with printing one language inside another, like CSS-in-JS lang:angular Issues affecting Angular template (not general JS/TS issues used for Angular) scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency type:bug Issues identifying ugly output, or a defect in the program
Milestone
2.7

Comments

@th0r
Copy link

th0r commented Jan 24, 2022

Prettier 2.5.1
Playground link

--parser angular

Input:

<ng-container *ngTemplateOutlet="someTmpl; context: {app}"></ng-container>

Output:

<ng-container
  *ngTemplateOutlet="someTmpl; context: { app: this.app }"
></ng-container>

Expected behavior:

<ng-container *ngTemplateOutlet="someTmpl; context: {app}"></ng-container>
@fisker fisker added area:multiparser Issues with printing one language inside another, like CSS-in-JS lang:angular Issues affecting Angular template (not general JS/TS issues used for Angular) type:bug Issues identifying ugly output, or a defect in the program labels Jan 24, 2022
@fisker fisker mentioned this issue Jan 24, 2022
Merged
@fisker
Copy link
Sponsor Member

fisker commented Jan 24, 2022

prettier/angular-estree-parser#222

@fisker fisker added the scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency label Jan 24, 2022
@fisker fisker modified the milestones: 2.6, 2.7 Mar 7, 2022
@fisker
Copy link
Sponsor Member

fisker commented Mar 13, 2022

I'm moving this to 2.7 milestone, the upstream PR hasn't reviewed.

@sosukesuzuki sosukesuzuki mentioned this issue Jun 11, 2022
Merged
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area:multiparser Issues with printing one language inside another, like CSS-in-JS lang:angular Issues affecting Angular template (not general JS/TS issues used for Angular) scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
2.7
Development

Successfully merging a pull request may close this issue.

Update angular-estree-parser sosukesuzuki/prettier
2 participants
@fisker @th0r