Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests #13540

Open
fisker opened this issue Sep 27, 2022 · 0 comments
Open

Update tests #13540

fisker opened this issue Sep 27, 2022 · 0 comments
Labels
type:tests Issues about tests that are not correct, should be added, or similar

Comments

@fisker
Copy link
Sponsor Member

fisker commented Sep 27, 2022 •
edited

We have index.cjs and index.js now, currently we only tested ESM version, we should run tests on both.

The bundled ESM standalone version also not well tested

prettier/tests/integration/__tests__/bundle.js

Line 35 in 3f21a97

describe("standalone", () => {
, better run full tests too.

Ideally, we should also run standalone version on both Node.js and a REAL browser.
@fisker fisker added the type:tests Issues about tests that are not correct, should be added, or similar label Sep 27, 2022
@fisker fisker mentioned this issue Oct 14, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:tests Issues about tests that are not correct, should be added, or similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fisker