Change AstPath#match()

[fisker]

The name argument in AstPath#match() seems work different than AstPath#each()/AstPath#map(). It is the key to access child, not the key to access node.

This confusing me, I hope we can change it.

1. Make name as the key to access node to consist with other method/getter.
2. Add a parent argument.

Take this as example,

https://github.com/prettier/prettier/blob/next/src/language-js/print/misc.js#L26-L30

    path.match(
      undefined,
      (node, name) =>
        name === "id" && node.type === "VariableDeclarator" && node.definite
    )

If we choose 1:

path.match(
  (_, name) => name === "id",
  (node) => node.type === "VariableDeclarator" && node.definite
)

If we choose 2:

path.match(
  (node, parent) => parent.type === "VariableDeclarator" && parent.definite && parent.id === node
)

I prefer 2nd choice.

WDYT? @thorn0

[thorn0]

I don't feel strongly about 1. But 2 looks strange. The idea of match is that there is a separate predicate for each level of the AST. Why mix levels in one predicate?

[fisker]

How about call callParent inside, so we get path as argument?

[thorn0]

What for? Do you have specific cases you want to improve this way?

BTW, what I'd like to have in match is support for alternatives, but that's quite a non-trivial feature to implement.