Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotion's keyframes are not getting formatted #13774

Closed
Kimzify opened this issue Nov 1, 2022 · 1 comment
Closed

Emotion's keyframes are not getting formatted #13774

Kimzify opened this issue Nov 1, 2022 · 1 comment
Labels
type:intended Bug reports that actually turned out to be intended behavior

Comments

@Kimzify
Copy link

Kimzify commented Nov 1, 2022

Prettier 2.7.1
Playground link

--parser babel

Input:

const enterKeyframe = keyframes`
  			from {
    opacity: 0.2;
  }
  to {
    opacity: 0.5;
  }
`;

Output:

const enterKeyframe = keyframes`
  			from {
    opacity: 0.2;
  }
  to {
    opacity: 0.5;
  }
`;

Expected behavior:

const enterKeyframe = keyframes`
 from {
   opacity: 0.2;
 }
 to {
   opacity: 0.5;
 }
`;
@kachkaev
Copy link
Member

kachkaev commented Nov 4, 2022

👋 @KimiyaHajizadeh! Supporting this case would be quite challenging because there may be another library with keyframes, in which formatting is not desired. See:

Possible solution (still requires discussion):

@kachkaev kachkaev closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2022
@kachkaev kachkaev added the type:intended Bug reports that actually turned out to be intended behavior label Nov 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:intended Bug reports that actually turned out to be intended behavior
Projects
None yet
Development

No branches or pull requests

2 participants