Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint config #15944

Closed
fisker opened this issue Jan 17, 2024 · 1 comment
Closed

Fix ESLint config #15944

fisker opened this issue Jan 17, 2024 · 1 comment
Labels
type:infra Issues about CI, publishing to npm, or similar

Comments

@fisker
Copy link
Member

fisker commented Jan 17, 2024

Due to ESLint ignore behavior change, we can't correctly lint files in tests/format/ except jsfmt.spec.js. eslint/eslint#17964 (comment)

We need update

tests/format/**/*.*
!tests/format/**/jsfmt.spec.js

to

# Ignore directories and files in `tests/format`
tests/format/**/*
# Unignore directories and `jsfmt.spec.js` file
!tests/format/**/
!tests/format/**/jsfmt.spec.js

To verify it works as expected,

  • Update tests/format/flow-repo/esproposal_class_instance_fields.warn/jsfmt.spec.js to use run_spec(__dirname, ["flow"])
  • Run yarn eslint tests/format/flow-repo/esproposal_class_instance_fields.warn/, should report error for jsfmt.spec.js but not other files.
@fisker fisker added the type:infra Issues about CI, publishing to npm, or similar label Jan 17, 2024
@fisker
Copy link
Member Author

fisker commented Jun 5, 2024

Fixed by #16208

@fisker fisker closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:infra Issues about CI, publishing to npm, or similar
Projects
None yet
Development

No branches or pull requests

1 participant