Funky formatting when using template strings as arguments

[pluma]

At ArangoDB (Apache 2.0 licensed NoSQL multi-model database with an embedded V8 environment) we're using an aql template tag to support queries without the risk of injection attacks (think SQL).

This means we have plenty of code that looks like this:

const result = db._query(aql`
  FOR x IN 1..5
  RETURN x
`).toArray();

However prettier seems to think that's unreadable and instead formats it as this:

const result = db
  ._query(
    aql`
  FOR x IN 1..5
  RETURN x
`
  )
  .toArray();

Curiously this seems to be triggered by the final .toArray(). Without it, prettier plays nice:

const result = db._query(aql`
  FOR x IN 1..5
  RETURN x
`);

The minimal test case seems to be this:

x.y(`
`).z();

Observations:

• x.y needs to be a method, using a function (x(...).z();) doesn't trigger the behaviour
• z() needs to be a method call, using a property access (x.y(...).z;) also doesn't trigger it (though something like x.y(...).z.a() triggers it again, as does x.y(...).z().a)
• the template string needs to contain at least one linebreak
• the length and content of the template string is otherwise irrelevant

So it seems to be doing the right thing UNLESS there's a second chained method call, even if the method takes no arguments.

[pluma]

Is there any more information I can provide?

Is this formatting intentional?

I'd submit a PR but I have no idea where to start. I'm not even sure how to read the test cases.

[azz]

I think it is the intended (or at least expected) behaviour for the template string to be indented.

If you want to have a crack at inlining it (tagged template expessions and raw template literals), that would be awesome.

The tests inputs are tests/*/*.js and snapshots contain the input , ~~~, and output.

There's more info in CONTRIBUTING