Small ternary issue && ... || ...

[drcmda]

Not that it made much sense in that case when ? ... : ... would do the same, i was trying to prevent a longer prettier output (? : would have added more lines)

Prettier 1.7.0
Playground link

--jsx-bracket-same-line
--print-width 120
--no-semi
--single-quote
--tab-width 4
--trailing-comma all

Input:

let test = {
    plugins: [
        new WebpackNotifierPlugin(),
        ...((env.prod && [
            new webpack.DefinePlugin({ 'process.env': { NODE_ENV: JSON.stringify('production') } }),
            new webpack.LoaderOptionsPlugin({ minimize: true, debug: false }),
            new webpack.optimize.UglifyJsPlugin({ compress: { warnings: false }, mangle: true }),
        ]) || []),
    ],
}

Output:

let test = {
    plugins: [
        new WebpackNotifierPlugin(),
        ...((env.prod && [
            new webpack.DefinePlugin({ 'process.env': { NODE_ENV: JSON.stringify('production') } }),
            new webpack.LoaderOptionsPlugin({ minimize: true, debug: false }),
            new webpack.optimize.UglifyJsPlugin({ compress: { warnings: false }, mangle: true }),
        ]) ||
            []),
    ],
}

Expected behavior:

I wouldn't expect the trailing [] to hang in the place prettier puts it right now.

[duailibe]

Indeed. Why do we only inline array and objects when they're not empty? i.e.

const foo =
  bar &&
  baz &&
  [];

const foo = bar &&
    baz && [0];

playground

[duailibe]

Okay now I get why it's like this.. goes back to #1342 but I'm not sure the fix was correct (i.e. the example above)

[AHH0623]

good