Glob pattern issues in 1.7.1

[icopp]

Input:

node_modules/.bin/prettier --parser json --write package.json

Output:

Unable to expand glob patterns: package.json !**/node_modules/** !./node_modules/**
TypeError: Cannot read property 'name' of undefined

Expected behavior:

Prettier runs and parses the given file

[suchipi]

I'm unable to reproduce; could you provide more info? What node version are you using?

[ikatyang]

I cannot reproduce, this is how I tested:

mkdir test && cd test && yarn --init && yarn add prettier && node_modules/.bin/prettier --parser json --write package.json

Can you share steps to reproduce?

[icopp]

node -v
v8.5.0

npm -v
5.4.2

Interestingly, making a new repo and testing there works fine. However, on my existing repo, 1.7.0 works fine while 1.7.1 fails. I'm trying to figure out what the difference is, but so far I can only think that there must be a dependency getting pulled in with a slightly different version that must be mucking things up.

[ikatyang]

Prettier bundled all the dependencies before publishing to npm, so that it's impossible to be affected by dependencies.

https://www.npmjs.com/package/prettier: 0 dependencies

[ikatyang]

I'm able to reproduce something like this in #2924 with single line js config:

mkdir test
cd test && yarn --init
yarn add prettier
echo 'module.exports = { semi: true };' > myConfig.js
echo 'const x = 1' > index.js
node_modules/.bin/prettier --config myConfig.js index.js

cosmiconfig parses myConfig.js as yaml (parsed = { "module.exports = { semi": "true };" }) causing invalid config error catched by this try...catch:

  try {
    const filePaths = globby
      .sync(patterns, { dot: true })
      .map(
        filePath =>
          path.isAbsolute(filePath)
            ? path.relative(process.cwd(), filePath)
            : filePath
      );
    if (filePaths.length === 0) {
      console.error(`No matching files. Patterns tried: ${patterns.join(" ")}`);
      process.exitCode = 2;
      return;
    }
    ignorer
      .filter(filePaths)
      .forEach(filePath =>
        callback(filePath, getOptionsForFile(argv, filePath)) // <-----------------
      );
  } catch (error) {
    throw error;
    console.error(
      `Unable to expand glob patterns: ${patterns.join(" ")}\n${error}` // <-------------
    );
    // Don't exit the process if one pattern failed
    process.exitCode = 2;
  }

---

Not sure if this is your case, can you share your config setting?

[bd82]

I have the same issue, tried creating a reproducing repo and surprisingly everything works...
I have a suspicion this is related to the file structure of he project.

[bd82]

Reproducible example here:
https://github.com/bd82/prettier_172_issue

The issue seems related to the existence of a "prettier" section in the package.json file.

I would hazard a guess this has something to do with default options behavior.

[ikatyang]

@bd82

It seems you're using incorrect config, no-semi is for CLI, you should write semi: false there, it'll just work fine, but we should show better warning message.

[bd82]

Thanks. @ikatyang

Was this changed? as the no-semi option was definitely working in 1.6

[ikatyang]

@bd82

Maybe it's caused by our original implementation, but it's never mentioned on official docs before, so it shouldn't be an issue.

[ikatyang]

I believe @icopp's issue is something like I mentioned above, opened cosmiconfig/cosmiconfig#95 to track it.

[icopp]

It's definitely the config file doing it.

When I have a .prettierrc file with these options, it breaks:

{
  "eslintIntegration": true,
  "semi": false,
  "singleQuote": true
}

When I have no such file, it works.

The eslintIntegration option is used by some editors as a setting lookup, and previously didn't cause any trouble.

[ikatyang]

OK, I think #2929 should fix it, sorry for causing such issue, I forgot there may be some unknown options while implementing the normalization.

[bd82]

Thanks @ikatyang