Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning is printed in master #3385

Closed
lydell opened this issue Dec 3, 2017 · 2 comments
Closed

Deprecation warning is printed in master #3385

lydell opened this issue Dec 3, 2017 · 2 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! type:infra Issues about CI, publishing to npm, or similar

Comments

@lydell
Copy link
Member

lydell commented Dec 3, 2017 

~/forks/prettier master ⇡ 
❯ git log -1
commit ceabc48e01b4b8977ae98f0b4bc774bd2659a294 (HEAD -> master, upstream/master, gql-cooked)
Merge: c1623d88 24036480
Author: Lucas Duailibe <lucasds@gmail.com>
Date:   2017-12-03 03:25:17 -0300

    Format CSS prop for emotion (#3381)

~/forks/prettier master ⇡ 
❯ echo a | ./bin/prettier.js 
[warn] `proseWrap` with value `false` is deprecated. Prettier now treats it as: `{ proseWrap: "never" }`.
a;
@lydell lydell added the type:bug Issues identifying ugly output, or a defect in the program label Dec 3, 2017
@lydell lydell added this to the 1.9 milestone Dec 3, 2017
@ikatyang
Copy link
Member

ikatyang commented Dec 3, 2017 •
edited

Uh, it's caused by our .prettierrc, we should update it to "never" after we released 1.9 I think.

prettier/.prettierrc

Lines 1 to 3 in ceabc48

{
"proseWrap": false
}

@ikatyang ikatyang added type:infra Issues about CI, publishing to npm, or similar and removed type:bug Issues identifying ugly output, or a defect in the program labels Dec 3, 2017
@ikatyang ikatyang removed this from the 1.9 milestone Dec 3, 2017
@lydell
Copy link
Member Author

lydell commented Dec 3, 2017

Phew!

@lydell lydell changed the title False deprecation warning is printed in master Deprecation warning is printed in master Dec 3, 2017
@azz azz mentioned this issue Dec 5, 2017
Merged
@ikatyang ikatyang added the status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! label Dec 5, 2017
@ikatyang ikatyang mentioned this issue Dec 14, 2017
Closed
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! type:infra Issues about CI, publishing to npm, or similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lydell @ikatyang