Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--insert-pragma removes duplicate @pragmas #3933

Closed
azz opened this issue Feb 9, 2018 · 1 comment
Closed

--insert-pragma removes duplicate @pragmas #3933

azz opened this issue Feb 9, 2018 · 1 comment
Assignees
@azz
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency type:bug Issues identifying ugly output, or a defect in the program
Milestone
1.11

Comments

@azz
Copy link
Member

azz commented Feb 9, 2018

Prettier 1.10.2
Playground link

--insert-pragma

Input:

/**
 * @x 1
 * @x 2
 */

Output:

/**
 * @format
 * @x 2
 */

Expected behavior:

/**
 * @format
 * @x 1
 * @x 2
 */

Fixed in jestjs/jest#5502
@azz azz added type:bug Issues identifying ugly output, or a defect in the program priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency labels Feb 9, 2018
@SimenB
Copy link
Contributor

SimenB commented Feb 10, 2018

jest-docblock 22.2.2 is available

@azz azz self-assigned this Feb 11, 2018
@azz azz mentioned this issue Feb 11, 2018
Merged
@azz azz added this to the 1.11 milestone Feb 11, 2018
@azz azz closed this as completed in #3947 Feb 11, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@azz azz

Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. priority:high Code is printed in a way that alters the AST, breaks syntax, or is a significant regression. Urgent! scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
1.11
Development

No branches or pull requests
2 participants
@azz @SimenB