Option Request: Multi-line formatting of object destructuring

[tennisgent]

A recent change from #4267 resulted in an intentional change in how objects are destructured. I've been using prettier now for a long time and I love it. But I used to be able to do something like this:

(edited by @duailibe)

Before

const { match: { params: { id } } } = this.props  // 1 line

After

const { 
    match: { 
        params: { id }   // 5 lines
    } 
} = this.props

And there are a number of other places where this has caused a number of extra lines of code (that IMO are less readable). So I'm requesting that this change be given a config option so I can disable just this one rule.

Thank you for your consideration, time and for putting such great work into prettier

[alexander-akait]

👎 on option
@tennisgent please provide example of code where you have less readable places

[j-f1]

How about only expanding the node onto multiple lines if:

• there are more than two keys in it that have children that are objects, OR
• one of its children has an object child that is expanded

[duailibe]

Hi @tennisgent, thanks for the report!

First of all, the catch one was unintended. For example, when in function arguments, we require one extra "level" in the hierarchy to break the destructuring, see the example in the playground. So in your specific example, it should behave the same.

I appreciate your comment and I certainly prefer the previous behavior, but we won't be adding any options for that. Instead, I'd like to tweak our heuristics to print them better.

Let's keep in mind this has been discussed at length on #2550

[duailibe]

Oh the handleClick case is already printed correctly:

Prettier 1.12.1
Playground link

Input:

function fn({target: {value}}) {}

const fn = ({target: {value}}) => {}

Output:

function fn({ target: { value } }) {}

const fn = ({ target: { value } }) => {};

[duailibe]

@tennisgent I edited the OP to remove the outdated examples. If you have more, report back!