Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourc #445

Closed
dazinator opened this issue Jan 24, 2017 · 1 comment
Closed

Sourc #445

dazinator opened this issue Jan 24, 2017 · 1 comment
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@dazinator
Copy link

dazinator commented Jan 24, 2017 •
edited

Am I right in thinking that sourcemap support wouldn't really make sense for this project as I'd assume if using sourcemaps (e.g to map back to original typescript etc) then you probably shouldn't bother formatting the js as it won't have any benefit?

Just throwing this out there in case anyone can see a benefit for sourcemap support that I can't.
@vjeux
Copy link
Contributor

vjeux commented Jan 24, 2017

Right now prettier doesn't support sourcemaps but it should be possible to without too much trouble given the way the project is setup.

However, the performance is a concern and we don't have any concrete use cases yet.

I'm goibg to close this issue as this is not actionable but feel free to keep commenting on it

@vjeux vjeux closed this as completed Jan 24, 2017
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vjeux @dazinator