Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understands .scss but not .sass files #4948

Closed
sprlwrksAprilmintacpineda opened this issue Aug 8, 2018 · 4 comments
Closed

Understands .scss but not .sass files #4948

sprlwrksAprilmintacpineda opened this issue Aug 8, 2018 · 4 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@sprlwrksAprilmintacpineda
Copy link

sprlwrksAprilmintacpineda commented Aug 8, 2018

I love this tool, hopefully I could use it with our sass files too.

I have tried the override option and run scss parser against our sass files but it did work out well it produced errors about semi colons (which I also explicitly set to false on the override), when I tried --write it broke the format.

Here's an example.

@alexander-akait
Copy link
Member

@sprlwrksAprilmintacpineda we don't support sass, only scss

@sprlwrksAprilmintacpineda
Copy link
Author

@evilebottnawi can we?

@alexander-akait
Copy link
Member

@sprlwrksAprilmintacpineda PR welcome, but it is require a lot of work

@sprlwrksAprilmintacpineda
Copy link
Author

Nah, I guess we'll use scss then.

For future readers who might want to convert from sass to scss to be able to use prettier (in case this is still not possible that time).

Do these:

// install sass to be able to use sass-convert
// more at https://sass-lang.com/documentation/
gem install sass

// convert all files in src directory from sass to scss
// note that this will not delete your original sass files
// instead it will create a file named [originalFileName].scss
// on the same directory as the sass file is.
sass-convert -F sass -T scss -R src/

// then if you want to delete the old sass files
find . -name "*.sass" -type f -delete
// but first you might want to check what you are deleting
find . -name "*.sass" -type f

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

2 participants