Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript bigint support #5545

Closed
vekexasia opened this issue Nov 24, 2018 · 3 comments
Closed

TypeScript bigint support #5545

vekexasia opened this issue Nov 24, 2018 · 3 comments
Labels
lang:typescript Issues affecting TypeScript-specific constructs (not general JS issues) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! type:enhancement A potential new feature to be added, or an improvement to how we print something
Milestone
1.15.3

Comments

@vekexasia
Copy link

Hey Typescript 3.2 has bigint support but prettier marks the following with an error:

let n = 1n;

Playground link
@j-f1 j-f1 added type:bug Issues identifying ugly output, or a defect in the program scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency lang:typescript Issues affecting TypeScript-specific constructs (not general JS issues) labels Nov 24, 2018
@ikatyang ikatyang mentioned this issue Nov 25, 2018
Merged
@ikatyang
Copy link
Member

Tracked in JamesHenry/typescript-estree#35.

@ikatyang ikatyang added type:enhancement A potential new feature to be added, or an improvement to how we print something and removed type:bug Issues identifying ugly output, or a defect in the program labels Nov 25, 2018
@ikatyang ikatyang added this to the 1.15.3 milestone Nov 25, 2018
@ikatyang ikatyang mentioned this issue Nov 25, 2018
Merged
5 tasks
@ikatyang ikatyang added the status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! label Nov 25, 2018
@vekexasia
Copy link
Author

Hello @ikatyang thanks for your work. I guess this will land in 1.15.3 right?

@ikatyang
Copy link
Member

Yes.

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
lang:typescript Issues affecting TypeScript-specific constructs (not general JS issues) locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency status:has pr Issues with an accompanying pull request. These issues will probably be fixed soon! type:enhancement A potential new feature to be added, or an improvement to how we print something
Projects
None yet
Milestone
1.15.3
Development

No branches or pull requests
3 participants
@vekexasia @ikatyang @j-f1