Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes new line at EOF when file has been reformatted #708

Closed
greggb opened this issue Feb 14, 2017 · 7 comments
Closed

Removes new line at EOF when file has been reformatted #708

greggb opened this issue Feb 14, 2017 · 7 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Comments

@greggb
Copy link

greggb commented Feb 14, 2017

Still seeing the behavior from #55 and #105

When formatting a file with the JSPrettier package in Sublime it removes the new line if any reformatting has been done. Looks they are using the latest version of prettier (https://github.com/jonlabelle/SublimeJsPrettier/blob/master/package.json).

Would this be specific to the plugin?

@vjeux
Copy link
Contributor

vjeux commented Feb 14, 2017

https://packagecontrol.io/ is down so I can't install it right now, but it's likely an issue with the package.

@vjeux
Copy link
Contributor

vjeux commented Feb 14, 2017

Note that this is using the globally installed version of prettier. If you do

npm ls -g prettier

you can see what version it uses.

@greggb
Copy link
Author

greggb commented Feb 15, 2017

Looks like I'm using prettier@0.17.1. I'll do some more digging to see if I can repro without this package

@vjeux
Copy link
Contributor

vjeux commented Feb 15, 2017

Thank you!

@vjeux
Copy link
Contributor

vjeux commented Feb 15, 2017

If you can run prettier file.js --write and repro locally that would be useful as well.

@greggb
Copy link
Author

greggb commented Feb 15, 2017

You're absolutely right, running from the command line works fine, but repros with the package. Sorry for erroneous issue!

@greggb greggb closed this as completed Feb 15, 2017
@vjeux
Copy link
Contributor

vjeux commented Feb 15, 2017

Thanks for raising it, we need to make sure that the prettier integrations are of high quality, this is a big part of the experience :)

@azz azz added status:awaiting response Issues that require answers to questions from maintainers before action can be taken and removed needs more info labels Oct 1, 2017
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2018
@j-f1 j-f1 removed the status:awaiting response Issues that require answers to questions from maintainers before action can be taken label Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

No branches or pull requests

4 participants