Don't look for a configuration file outside the project directory

[thorn0]

When looking for the .editorconfig file, Prettier doesn't climb all the way up the file system. It finds the 'project (repository) root' and stops there. It would make sense to adjust the resolution of configuration files the same way.

• Prettier should be configured on the project-level, its configuration should be part of the project.
• It's encouraged to use Prettier with default settings, which means without a configuration file. It also means that if there is a configuration file in some parent directory, it can unexpectedly affect formatting.
• It's inconsistent that .editorconfig and .prettierrc are resolved differently.

But this would be a breaking change.

Thoughts?

[fisker]

prettier/.editorconfig

Line 1 in b5f3948

root = true

prettier/.eslintrc.yml

Line 1 in b5f3948

root: true

[thorn0]

@fisker Unlike ESLint and EditorConfig, Prettier's configuration file isn't hierarchical. Once it's found, the resolution process stops, so it's always "root" anyway. But I'm also talking about a use case when there is no configuration file at all. If the user wants to use all the defaults, they don't need a config file. Looks like the docs should recommend doing this for now:

prettier/.prettierrc

Line 1 in d47a225

{}

[QimatLuo]

git clone repo_with_prettier_configed
cd repo_with_prettier_configed
git submodule add repo_with_empty_prettier_config

In this case, the submodule folder with prettier empty config {} still not work, it get affected by parent config.
But if it's not a submodule, just a normal folder, then it works with empty config {} without get affect by parent config.

To me it's a bug.
Because the person who work with submodule will get different behavior even though the submodule setup correct itself.

[thorn0]

@QimatLuo Is your message about the current behavior of Prettier or about the logic proposed in this issue? If former, please provide more specific reproduce steps and a sample repo on GitHub. (I must notice though that Prettier doesn't have a notion of "parent config". Configs aren't hierarchical.)

[QimatLuo]

@QimatLuo Is your message about the current behavior of Prettier or about the logic proposed in this issue? If former, please provide more specific reproduce steps and a sample repo on GitHub. (I must notice though that Prettier doesn't have a notion of "parent config". Configs aren't hierarchical.)

Cannot replicate with newest prettier version.
I'm good now.

[fisker]

Pass this

prettier/src/config/resolve-editorconfig.js

Line 8 in b1f4d95

root: findProjectRoot(path.dirname(path.resolve(filePath))),

as stopDir option should fix this.

[fisker]

I'm going to postpone this, can't get it done before v3 release.

[buckley310]

Related? #13538
The editorconfig spec actually says the search should proceed outside the project directory.

[fisker]

We'll accept this.

[pronebird]

Can anyone explain please, I have .editorconfig two levels above where I run prettier and it seems to be completely oblivious that there is ../../.editorconfig with root = true inside.