Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline support for Playground #8763

Open
umeshgmrl opened this issue Jul 15, 2020 · 8 comments
Open

Offline support for Playground #8763

umeshgmrl opened this issue Jul 15, 2020 · 8 comments
Assignees
@DanBeckDev
Labels
area:playground Issues about the playground (https://prettier.io/playground) help wanted We're a small group who can't get to every issue promptly. We’d appreciate help fixing this issue! type:enhancement A potential new feature to be added, or an improvement to how we print something

Comments

@umeshgmrl
Copy link

Prettier playground should be an installable PWA so that it can be used offline

https://prettier.io/playground/
@fisker fisker added area:playground Issues about the playground (https://prettier.io/playground) help wanted We're a small group who can't get to every issue promptly. We’d appreciate help fixing this issue! type:enhancement A potential new feature to be added, or an improvement to how we print something labels Jul 15, 2020
@DanBeckDev
Copy link

I would love you give this a go. Can I be assigned this?

@DanBeckDev
Copy link

@fisker For the PWA it is required to have an icon of atleast 512x512px. Do you know where I could look to find this?

@fisker
Copy link
Member

fisker commented Jul 18, 2020

Thank you.

Icon https://github.com/prettier/prettier-logo

@DanBeckDev
Copy link

@fisker I have got the core functionality working for the PWA.

How would you like to make it installable? Do we want a banner which pops up to prompt the user?

I have also noticed that the existing service worker you have implimented is currently depecriated (sw-toolbox) in favor of Workbox. Would you like me to tackle this as well?
https://github.com/GoogleChromeLabs/sw-toolbox/

@fisker
Copy link
Member

fisker commented Jul 25, 2020 •
edited

How would you like to make it installable?

I think a install button is good.

@fisker
Copy link
Member

fisker commented Jul 25, 2020

I have also noticed that the existing service worker you have implimented is currently depecriated (sw-toolbox) in favor of Workbox. Would you like me to tackle this as well?

Sure.

@umeshgmrl umeshgmrl reopened this Sep 7, 2020
@umeshgmrl
Copy link
Author

Sorry I've mistakenly closed this issue,

BTW any update?

@DanBeckDev
Copy link

Hi, sorry I have been struggling with this. I have managed to make it all work offline but I am struggling to convert it all over to sw-toolbox. I can create a PR and see what you guys think about my current implementation?

@fisker fisker mentioned this issue Nov 17, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanBeckDev DanBeckDev

Labels
area:playground Issues about the playground (https://prettier.io/playground) help wanted We're a small group who can't get to every issue promptly. We’d appreciate help fixing this issue! type:enhancement A potential new feature to be added, or an improvement to how we print something
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fisker @umeshgmrl @DanBeckDev