Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to disable 'single-quote' #32

Closed
CGamesPlay opened this issue Jul 31, 2017 · 5 comments
Closed

Unable to disable 'single-quote' #32

CGamesPlay opened this issue Jul 31, 2017 · 5 comments

Comments

@CGamesPlay
Copy link

Prettier 1.5.3 does not accept --single-quote false as a way to using double quotes. This means that g:prettier#config#single_quote = 'false' doesn't work. I have to use this, which is icky: g:prettier#config#single_quote = '--no-single-quote'.

@mitermayer
Copy link
Member

Thanks for reporting this, will look into it and do a release ASAP, otherwise also accepting PR

@mitermayer
Copy link
Member

@CGamesPlay Will do a new release in the next day or two to fix this

@mitermayer mitermayer self-assigned this Aug 2, 2017
@mitermayer mitermayer added the bug label Aug 2, 2017
@mitermayer
Copy link
Member

@CGamesPlay I am unable to reproduce this bug, can you please help me understand how is that happening to you?

Steps I have done to try to reproduce this bug (using prettier 1.5.2 and 1.5.3):

  1. added this line to my .vimrc:
g:prettier#config#single_quote = 'false' 
  1. created a dummy file (foo.js) with this contents:
const a = 'foo';
  1. Open foo.js with vim then run :Pretter

From doing the above I got the same result both times:

const a = "foo";

Would be great if you could provide me some more information on how to reproduce this error

@mitermayer
Copy link
Member

@CGamesPlay Will be closing this issue since I can't reproduce it. Feel free to re-open it if you can provide more information on how to reproduce it.

thank you for reporting it :)

@mitermayer mitermayer removed the bug label Aug 6, 2017
@mitermayer mitermayer removed their assignment Aug 6, 2017
@CGamesPlay
Copy link
Author

No worries. I'll collect my versions and try again. It's possible I wasn't setting the variables correctly? Will double check and report back if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants