-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using prettier-eslint-cli #42
Comments
@mightyguava thanks for submitting this issue, In the past we had also been requested to add support for other CLI's ( So maybe now it make sense to revisit this and enable it to be configurable for other CLI's. |
Still interested on working in this issue, will prioritize bumping vim-prettier to support the new prettier 1.6 features then get back to this issue |
can I use prettier-eslint-cli by this config |
Hi @dedoyle, The so if you do on the CLI
To answer your question, |
I'm looking forward to you to complete this issue. Atom has a prettier-atom, and I had tried it. It feels great. But I still hope I can do it in vim, do not want to leave vim to atom. Thank you very much for vim-prettier. |
Hi @dedoyle,
example of one (https://github.com/facebook/draft-js/blob/master/prettier.config.js): module.exports = {
singleQuote: true,
trailingComma: 'all',
bracketSpacing: false,
jsxBracketSameLine: true,
parser: 'flow',
}; |
@dedoyle This is one reason as far as know to use prettier-eslint Any plans to support prettier-eslint-cli? |
Hi @alex-shamshurin , It is on our roadmap for 1.0 release https://github.com/prettier/vim-prettier/projects/1, still trying to find time to action on it. Before starting adding support for other CLI's I want to setup the automated testing infrastructure for |
Hi, is there any update? |
Do people still think its worth integrating with other CLI's ? or is the prettier configuration settings via |
It will be great to support prettier-eslint-cli |
I don't think you can get the functionality of |
If some option, like 'use_eslint_fix' is set then it should read one of eslint config files and run eslint --fix after prettier. |
Are you saying such an option exists and that it is the same as Or that it would be good if such an option exists? |
It should not be limited to ESLint only (I use csslint as well and it acts on different file extensions), and instead should be configurable. I think having a situation where the tools to be ran on which file-type much like |
This is same as #148 |
Can this be configured to use https://github.com/prettier/prettier-eslint-cli? We have some eslint rules that are incompatible with prettier that work great with the alternate CLI. It's also a great tool as we try to migrate to prettier without completely turning off eslint
The text was updated successfully, but these errors were encountered: