-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Chrome and Firefox font selectors #169
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, I appreciate you contributing to the project
src: url(chrome-extension://__MSG_@@extension_id__/fonts/RedHatText-Regular.ttf), | ||
url(moz-extension://__MSG_@@extension_id__/fonts/RedHatText-Regular.ttf); | ||
src: local(RedHatText-Regular.ttf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, local()
loads the font if it is already installed. But can we assume that everyone who uses the extension has this font installed? Supplying it only as a local file is not enough for this, as I understand it. Or am I wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes.. You're right.
Not sure if we can make that assumption, I don't remember installing the font but that doesn't mean it didn't come with some other software (nor that it would be pre-installed in every setup). It would require some investigation at very least and even then it could be bad idea to assume such.
As such, this proposed fix isn't viable. I'll do some digging to see if better solution exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some digging to see if better solution exists
Thank you 😃 I'm also still looking into it and I'll comment if I stumble across anything helpful.
Resolves #163
Tested on Windows 11 22H2
Firefox 114.0.1 (64-bit) and Google Chrome Version 114.0.5735.134 (Official Build) (64-bit)