History search semi-broken

[pikeas]

Start with a simple command:

$ ls -a
...
$ ls -l
....

Now hit ctrl-r and type ls. The most recent result will populate. Hit ctrl-r again.
Expected: ls -a.
Actual: failing bck-i-search: ls.

Doing a search by typing ls and then up/down still works as expected.

Recently upgraded to your fork, what's the recommended way to debug this?

[facastagnini]

Hey @pikeas thanks for your report.
I will be afk for a few weeks, I will take a look at this as soon I am able.

[pikeas]

I found zsh-users/zsh-syntax-highlighting#407, which indicates an upstream problem in zsh itself!

I've compiled zsh from their master branch and ctrl-r appears to work as expected.

Is this worth a note on the history-search module's README?

[paulmelnikow]

Good find @pikeas! Would you mind opening a PR for that?

[facastagnini]

@pikeas can you pot a reference to the commit it od the head of zsh when you compiled and worked? I want to identify the version that includes that fix in zsh.

[pikeas]

@facastagnini I compiled zsh-users/zsh@64c6758, which was HEAD at the time I figured this out.

[johnpneumann]

I have 5.2 and do not have the issue.