Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readout function in mpnn and mpnn_ggcn #7

Closed
zeal-up opened this issue Apr 25, 2019 · 1 comment
Closed

Readout function in mpnn and mpnn_ggcn #7

zeal-up opened this issue Apr 25, 2019 · 1 comment

Comments

@zeal-up
Copy link

zeal-up commented Apr 25, 2019

In the original paper, the readout function is different between ggcn and the function used in the paper. But I noticed that you implement them as the same function.
Have I missed something?

@priba
Copy link
Owner

priba commented Apr 25, 2019

Hi @zeal-github

In the original paper the authors make use of the set2set network as a Readout. We didn't implement it here and we have used the same proposed in the ggcn. It is in the TODO list https://github.com/priba/nmp_qc/tree/master/models

@priba priba closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants