Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: Accordion #205

Open
hakimelek opened this issue Jan 16, 2018 · 6 comments
Open

New Component: Accordion #205

hakimelek opened this issue Jan 16, 2018 · 6 comments
Assignees
Labels
enhancement new component Proposal for new component v4

Comments

@hakimelek
Copy link
Collaborator

An example from Rental Cars Checkout page:
image

@krevat krevat assigned krevat and unassigned krevat Jan 31, 2018
@lauradhahn
Copy link
Contributor

@odmln this might be an interesting one to explore from a design standpoint. We have different chevron placements throughout the site and they're all initiating different types of interactions. Some things to consider:

  • Is a chevron the right indicator for an accordion interaction?
  • Could the accordion behavior be applied to a number of different page elements?
  • If so, what placement/indicator would be most flexible?

image

image

@jxnblk
Copy link
Contributor

jxnblk commented Apr 20, 2018

Fun fact You can do this in GH-Flavored Markdown

@James300 James300 added the v3 label Nov 14, 2019
@James300 James300 changed the title Consider adding Accordion component New Component: Accordion Nov 15, 2019
@James300 James300 self-assigned this Nov 18, 2019
@James300
Copy link
Collaborator

New Component: Accordion

@James300
Copy link
Collaborator

I'll wait until v4 for this since that is when we are doing the bump to hooks and it seems pointless to remake this component right after building it.

@craigpalermo craigpalermo added new component Proposal for new component and removed v3 labels Apr 3, 2020
@sdalonzo
Copy link
Collaborator

sdalonzo commented Apr 3, 2020

FYI I created this component internally, and it could be promoted to the Design System as soon as we bump the React peer floor to support hooks.

@craigpalermo
Copy link
Collaborator

Blocked by #711

@pcln-james pcln-james added the v4 label Apr 20, 2020
@pcln-james pcln-james self-assigned this May 4, 2020
@craigpalermo craigpalermo added this to TODO / Proposed in Release Design System v4 via automation Jul 7, 2020
@craigpalermo craigpalermo removed this from TODO / Proposed in Release Design System v4 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new component Proposal for new component v4
Projects
None yet
Development

No branches or pull requests

8 participants