Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: Carousel #350

Open
jes708 opened this issue Aug 16, 2018 · 5 comments
Open

New Component: Carousel #350

jes708 opened this issue Aug 16, 2018 · 5 comments
Assignees
Labels
new component Proposal for new component v3

Comments

@jes708
Copy link
Collaborator

jes708 commented Aug 16, 2018

Should the design-system host a carousel component?

@jxnblk
Copy link
Contributor

jxnblk commented Aug 16, 2018

I think if we do add one, it should be an optional package. We'll probably want a monorepo setup for things like this in the near future

@jes708
Copy link
Collaborator Author

jes708 commented Sep 14, 2018

Here's a carousel that accepts any children as carousel items. This can possibly serve as a design-system carousel

screen shot 2018-09-14 at 2 41 18 pm

@jes708
Copy link
Collaborator Author

jes708 commented Nov 6, 2018

In progress #408

@James300 James300 added the v3 label Nov 14, 2019
@James300 James300 changed the title Carousel New Component: Carousel Nov 15, 2019
@craigpalermo craigpalermo added the new component Proposal for new component label Apr 3, 2020
@sdalonzo
Copy link
Collaborator

sdalonzo commented Apr 3, 2020

Something very similar was recently implemented by @dgiraldo313 in the internal monorepo and could be promoted to Design System once we bump the React peer floor to support Hooks.

@craigpalermo
Copy link
Collaborator

Blocked by #711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component Proposal for new component v3
Projects
None yet
Development

No branches or pull requests

6 participants